Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetR #43

Merged
merged 24 commits into from
Apr 11, 2024
Merged

SetR #43

merged 24 commits into from
Apr 11, 2024

Conversation

GabrielBG0
Copy link
Collaborator

@GabrielBG0 GabrielBG0 commented Feb 22, 2024 •
edited
Loading

Planned Features

  • vit
  • setr

@GabrielBG0 GabrielBG0 linked an issue Feb 22, 2024 that may be closed by this pull request
SetR #24
Closed
@GabrielBG0 GabrielBG0 changed the title SetR SetR --Draft-- Feb 22, 2024
@GabrielBG0
Copy link
Collaborator Author

@otavioon take a look in this vit implementation, does it makes sense? I got it and adapted from SetR repo but idk if its the best way to do it

@GabrielBG0 GabrielBG0 self-assigned this Feb 23, 2024
@GabrielBG0 GabrielBG0 requested a review from otavioon March 13, 2024 07:32
@GabrielBG0 GabrielBG0 changed the title SetR --Draft-- SetR Mar 13, 2024
@GabrielBG0
Copy link
Collaborator Author

All good i guess, ready for review

@otavioon
Copy link
Collaborator

Nice! I will take a look shortly! :D

otavioon
otavioon reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

otavioon
otavioon approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBG0 GabrielBG0 merged commit fd6e376 into main Apr 11, 2024
@GabrielBG0 GabrielBG0 deleted the 24-setr branch April 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavioon otavioon otavioon approved these changes

Assignees

@GabrielBG0 GabrielBG0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetR
2 participants
@GabrielBG0 @otavioon